ci: add nameserver 1.1.1.1 to conformance-runtime test LVM #29455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/bug
mhofstetter
force-pushed
the
pr/mhofstetter/runtime-dns-fix
branch
2 times, most recently
from
bd1bdb0
to
b1d7bc0
Compare
|
/ci-runtime |
With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/runtime-dns-fix
branch
from
b1d7bc0
to
357fe69
Compare
|
/test |
brb
approved these changes
Nov 29, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
I don't think it's necessary. All other cases that use the LVH are working fine. @brb I think it would be better to check the status of the resolver in the VM before allowing commands via the github actions API. e.g. solving in the LVH. WDYT? |
SGTM. |
8 tasks
tklauser
added
the
needs-backport/1.14
tklauser
added
the
needs-backport/1.13
|
FYI, I've marked this PR to be backported to |
giorio94
added
backport-pending/1.13
giorio94
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.13
gentoo-root
moved this from Needs backport from main
to Backport done to v1.13
in 1.13.11
gentoo-root
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.6
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the property
dns-resolverto set a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error.The assumption is that the local DNS resolver isn't ready at that time when pulling the cilium docker plugin image (rather early after startup).
Therefore, this commit temporarily re-adds the nameserver
1.1.1.1manually in the runtime test - at the beginning of/etc/resolv.conf- and therefore prioritized.See: cilium/little-vm-helper#118